This repository was archived by the owner on Feb 4, 2022. It is now read-only.
Pin Servers during Sharded Transactions #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
force-pushed
the
NODE-1743/pin-sharded-transactions
branch
from
dc3ef29 to
e4f1af7
Compare
mbroadst
force-pushed
the
NODE-1743/pin-sharded-transactions
branch
from
6bd55c7 to
9a63109
Compare
daprahamian
force-pushed
the
NODE-1743/pin-sharded-transactions
branch
from
9a63109 to
8e0c9f9
Compare
daprahamian
changed the title
mbroadst
force-pushed
the
NODE-1743/pin-sharded-transactions
branch
from
a466b0c to
5db3c1b
Compare
daprahamian
force-pushed
the
NODE-1743/pin-sharded-transactions
branch
from
5db3c1b to
01a2fa8
Compare
mbroadst
force-pushed
the
NODE-1743/pin-sharded-transactions
branch
from
204d313 to
dc02410
Compare
mbroadst
force-pushed
the
NODE-1743/pin-sharded-transactions
branch
from
03de14a to
2ae6b4f
Compare
daprahamian
commented
Feb 27, 2019
| const session = options.session; | ||
| const transaction = session && session.transaction; | ||
|
|
||
| if (isSharded && transaction && transaction.server) { |
There was a problem hiding this comment.
mongos.js has a protection here to ensure that the pinned server is actually connected. Should we do that here?
There was a problem hiding this comment.
I think that's because the old mongos doesn't have proper server selection. Anyway, I think it's too defensive to check here and I'd rather fix this holistically in our new topology if the issue comes up.
daprahamian
commented
Feb 27, 2019
lib/transactions.js
Outdated
| return; | ||
| } | ||
|
|
||
| throw new MongoError( | ||
| `Attempted illegal state transition from [${this.state}] to [${nextState}]` | ||
| ); | ||
| } | ||
|
|
||
| get isPinned() { |
There was a problem hiding this comment.
it looks like get isPinned is defined twice here, and not actually used.
mbroadst
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to ensure that all commands in a sharded transaction run against a single
mongos.Items to still do: