This repository was archived by the owner on Jan 20, 2025. It is now read-only.
fix: emit new event specifically when all data has been written to disk #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `finish` event on the target Writable itself would not indicate this when gzip compression is being used, because the gzip stream could finish before the subsequent `fs.write` call to the actual target file was completed. This could truncate the file in cases where the application quits immediately after the 'finish' event was emitted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
finishevent on the target Writable itself would not indicatethis when gzip compression is being used, because the gzip stream
could finish before the subsequent
fs.writecall to the actualtarget file was completed. This could truncate the file in cases
where the application quits immediately after the 'finish' event
was emitted.