Skip to content

Conversation

blva
Copy link
Collaborator

@blva blva commented Aug 28, 2025

Proposed changes

  • fix and adapt deviceId to use cjs and esm

Checklist

@blva blva changed the title fix: deviceId method fix: adapt deviceId import to cjs and esm Aug 28, 2025
@blva blva marked this pull request as ready for review August 28, 2025 15:17
@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 15:17
@blva blva requested a review from a team as a code owner August 28, 2025 15:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the deviceId module to support both CommonJS (CJS) and ECMAScript modules (ESM) by replacing a static import with dynamic import and handling both module formats.

Key changes:

  • Replace static import of node-machine-id with dynamic import
  • Add logic to handle both CJS and ESM module exports
  • Convert the getMachineId method to use async/await pattern

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@blva blva merged commit 1264ab2 into main Aug 28, 2025
20 of 25 checks passed
@blva blva deleted the deviceId branch August 28, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants