chore: bump @mongosh dependencies
#574
Conversation
Updates the mongosh service provider. Among other things, this allows us to no longer be broken with mongosh VSCode tests and keep alignment.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MongoDB shell dependencies to newer versions to maintain compatibility with VS Code MongoDB extension tests and keep alignment between projects.
- Updates
@mongosh/arg-parserfrom version 3.14.0 to 3.19.0 - Updates
@mongosh/service-provider-node-driverfrom version 3.12.0 to 3.17.0 - Removes the boolean parameter from the
close()method call to match the updated API
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates mongosh dependency versions to newer releases |
| src/common/connectionManager.ts | Updates service provider close method call to match new API signature |
gagik
changed the title
@mongosh dependencies@mongosh, mongodb dependencies
|
I see that with this change the OIDC tests are failing with a timeout. Maybe there is a breaking change somewhere in the node provider? I'll take a look too and see if we can get it working. |
gagik
changed the title
@mongosh, mongodb dependencies@mongosh dependencies
I think devtools connect bump should fix it. |
|
Yeah, OIDC tests only run on Linux (because the server only supports it in Linux) so if you see an ubuntu only issue, it's likely OIDC. I'm debugging and it seems that the issue is that the OIDC flow never finishes, the connection manager stays on "connecting", like when the user never confirms the authentication. |
package.json
Outdated
| "@mongodb-js/devtools-proxy-support": "^0.5.3", | ||
| "@mongosh/arg-parser": "^3.19.0", | ||
| "@mongosh/service-provider-node-driver": "^3.17.0", | ||
| "@vitest/eslint-plugin": "^1.3.4", |
|
I've actually found the breaking change. I'm trying to fix it now. It seems that there has been a change in the node provider that now opens the connection eagerly, instead of lazily, and this breaks our flow. |
…ntract NodeDriverServiceProvider.connect would return a Promise that was lazily connected. However, now, blocks until there is a ping from the server, forcing a connection. This would usually be fine, however, in OIDC it would mean blocking the whole MCP flow until the OIDC flow is connected. With the previous version, this was already handled, but now we need to split the logic a bit more to ensure that OIDC flows stay async.
connection string was valid
| name: "switch-connection", | ||
| arguments: { | ||
| connectionString: "mongodb://localhost:12345", | ||
| connectionString: "mangobd://localhost:12345", |
There was a problem hiding this comment.
Why the change here? I don't suppose there's anything on port 12345 anyway.
There was a problem hiding this comment.
This was testing something different: mongodb://localhost:12345 is not an invalid URL, it's just an URL where there is no MongoDB cluster.
src/common/connectionManager.ts
Outdated
| if (isOidcConnection) { | ||
| this.changeState("connection-request", { | ||
| tag: "connecting", | ||
| serviceProvider, | ||
| connectedAtlasCluster: settings.atlas, | ||
| connectionStringAuthType, | ||
| oidcConnectionType: connectionStringAuthType as OIDCConnectionAuthType, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Not sure why this was moved up here - it seems like we're returning it immediately a little bit later anyway.
…gagik/mongosh-bump
|
Tested the new connections on VSCode and works well. Thank you @kmruiz for looking into this! |
Updates the mongosh service provider. Among other things, this allows us to no longer be broken with mongosh VSCode tests and keep alignment.
Needed for mongodb-js/vscode#1130