chore: stop waiting for cluster deletion #607
Merged
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes test execution speed by modifying cluster deletion behavior to not wait for completion, only sending the deletion command.
Key Changes:
- Replaced
deleteAndWaitClusterwith a newdeleteClusterfunction that doesn't wait for deletion to complete - Added eslint disable comment to preserve the original function for potential cleanup script usage
nirinchev
reviewed
Oct 2, 2025
| } | ||
| } | ||
|
|
||
| async function deleteCluster(session: Session, projectId: string, clusterName: string): Promise<void> { |
There was a problem hiding this comment.
Rather than creating a new function, consider adding an argument to the existing one that indicates whether to wait for the deletion or not.
Pull Request Test Coverage Report for Build 18192134230Details
💛 - Coveralls |
nirinchev
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist