Skip to content

Conversation

himanshusinghs
Copy link
Collaborator

@himanshusinghs himanshusinghs commented Oct 7, 2025

Proposed changes

We need to keep yargs-parser pinned to v21 because it eventually ends up on the library path of mongodb-mcp-server which gets bundled in VSCode extension and yargs-parser@22 is not compatible with webpack (does not work at all) and creates issues like mongodb-js/vscode#1149

So until we find a way to remove yargs-parser from the lib path, which should be doable, we need to keep yargs-parser pinned to v21.

Checklist

@himanshusinghs himanshusinghs requested a review from a team as a code owner October 7, 2025 10:11
@himanshusinghs himanshusinghs requested review from Copilot and removed request for a team October 7, 2025 10:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the yargs-parser dependency from version 22 to version 21.1.1 to resolve webpack compatibility issues when bundling the MCP server for VS Code extensions.

  • Pins yargs-parser to version 21.1.1 instead of using the caret range ^22.0.0
  • Reorganizes @vitest/eslint-plugin in the devDependencies list

@himanshusinghs himanshusinghs enabled auto-merge (squash) October 7, 2025 10:25
@himanshusinghs himanshusinghs merged commit 2aa8f85 into main Oct 7, 2025
18 checks passed
@himanshusinghs himanshusinghs deleted the chore/downgrade-yargs-parser branch October 7, 2025 10:28
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 18309555363

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 82.462%

Files with Coverage Reduction New Missed Lines %
src/common/atlas/apiClient.ts 2 76.58%
Totals Coverage Status
Change from base Build 18276805864: -0.04%
Covered Lines: 5294
Relevant Lines: 6308

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants