chore: allow providing Voyage AI API key from config and tests to ensure unusable tools are not registered MCP-233 MCP-237 #622
+72
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the MongoDB MCP Server by adding support for the Voyage AI API key configuration and ensuring tools that depend on external services are properly validated before registration. The changes address two tickets: allowing Voyage AI API key configuration and preventing unusable tools from being registered.
- Adds
voyageApiKeyconfiguration parameter with environment variable support - Implements tool validation mechanism to prevent registration of tools without required dependencies
- Adds comprehensive tests to verify tools are properly filtered based on their availability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/common/config.ts |
Adds voyageApiKey configuration option with default empty value |
src/server.ts |
Adds optional toolConstructors parameter to enable dependency injection for testing |
tests/integration/tools/mongodb/mongodbTool.test.ts |
Adds test coverage for tool validation and refactors existing tests to use dependency injection |
README.md |
Documents the new voyageApiKey configuration parameter |
himanshusinghs
commented
Oct 7, 2025
| telemetry: Telemetry; | ||
| elicitation: Elicitation; | ||
| connectionErrorHandler: ConnectionErrorHandler; | ||
| toolConstructors?: (new (params: ToolConstructorParams) => ToolBase)[]; |
There was a problem hiding this comment.
This is only to make it easy to test tool registration behaviour.
Pull Request Test Coverage Report for Build 18317866080Details
💛 - Coveralls |
kmruiz
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Addresses both MCP-233 and MCP-237.
Apparently we always had a way to not register given certain conditions (ToolBase.verifyAllowed), I just added a test to verify the behaviour.
Checklist