feat: added atlas local deployment id to telemetry #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Oct 9, 2025
blva
reviewed
Oct 9, 2025
| return this.executeWithAtlasLocalClient(client, ...args); | ||
| } | ||
|
|
||
| protected async lookupDeploymentIdAndAddToTelemetryMetadata(client: Client, containerId: string): Promise<void> { |
There was a problem hiding this comment.
nit - you're not really adding it to telemetry metadata, you're just setting the deploymentId right?
There was a problem hiding this comment.
This was the best name I could think of. I'm open to suggestions.
There was a problem hiding this comment.
lookupDeploymentId, setDeploymentId, updateDeploymentId - I think you're doing only one thing, no need for the AndAdd...
There was a problem hiding this comment.
Thanks, I went with lookupDeploymentId.
blva
reviewed
Oct 9, 2025
blva
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added atlas local deployment ID to telemetry.
Jira: [MCP-160] [mongodb-mcp-server] Update existing MongoDB telemetry