fix(service-provider-server): fix change stream .next() interrupt #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose-m
approved these changes
Jul 13, 2021
…GOSH-888 When a user interrupts running code while a change stream `.next()` call is running, that closes the network connection. However, network errors are considered retryable by the driver (in line with the spec); this makes the change stream cursor `.next()` operation attempt to re-try itself, which fails because the MongoClient is already unusable at that point. In order to address this, we call the driver-internal `Connection.handleIssue()` method (which should be okay, since the relevant code here is concerned only with driver internals anyway) with a non-network-error state, which still closes ongoing operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONGOSH-888
When a user interrupts running code while a change stream
.next()call is running, that closes the network connection. However,
network errors are considered retryable by the driver (in line
with the spec); this makes the change stream cursor
.next()operation attempt to re-try itself, which fails because the
MongoClient is already unusable at that point.
In order to address this, we call the driver-internal
Connection.handleIssue()method (which should be okay, since therelevant code here is concerned only with driver internals anyway)
with a non-network-error state, which still closes ongoing operations.