fix(cli-repl): return original evaluation value to REPL MONGOSH-902 #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning the ShellResult interpretation of the evaluation result back to the Node.js REPL, return the original raw value and keep the ShellResult stored separately (which still needs to happen during `eval`, as the formatting itself is a synchronous operation). This ensures that `_` will always refer to the actual value of the last evaluation result.
rose-m
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning the ShellResult interpretation of the evaluation
result back to the Node.js REPL, return the original raw value and
keep the ShellResult stored separately (which still needs to happen
during
eval, as the formatting itself is a synchronous operation).This ensures that
_will always refer to the actual value of thelast evaluation result.