feat: add --build-info cli flag MONGOSH-896 #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of this: - Rename the analytics config writer part of the build package and add information other than the Segment API key to it - Clean up some functions in the build package to just take a config argument instead of a list of arguments with names that differ between call site and function definition (this was super confusing before, and still is in a lot of places) - Make sure that the compiled binary identifies itself as such in the evergreen script
rose-m
approved these changes
Jul 16, 2021
| outDir: path.dirname(bundleOutputFile), | ||
| outFile: path.basename(bundleOutputFile), | ||
| const bundler = new Bundler(config.input, { | ||
| outDir: path.dirname(config.execInput), |
There was a problem hiding this comment.
Yeah I remember being confused by the name execInput here as the outFile for the bundle. Maybe we can rename execInput to bundleFile inside config? (no need to do in that PR)
There was a problem hiding this comment.
Yes, I’m very much up for renaming a number of config options :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this:
and add information other than the Segment API key to it
a config argument instead of a list of arguments with names
that differ between call site and function definition (this
was super confusing before, and still is in a lot of places)
in the evergreen script