Skip to content

feat(cli-repl): mark exceptions from mongoshrc as such MONGOSH-911 #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2021
Merged

feat(cli-repl): mark exceptions from mongoshrc as such MONGOSH-911 #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/cli-repl/src/cli-repl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,14 @@ describe('CliRepl', () => {
await cliRepl.start('', {});
expect(output).to.include('reached five');
});

it('if an exception is thrown, indicates that it comes from mongoshrc', async() => {
await fs.writeFile(path.join(tmpdir.path, '.mongoshrc.js'), 'throw new Error("bananas")');
cliRepl = new CliRepl(cliReplOptions);
await cliRepl.start('', {});
expect(output).to.include('Error while running ~/.mongoshrc.js:');
expect(output).to.include('Error: bananas');
});
});

context('files loaded from command line', () => {
Expand Down
1 change: 1 addition & 0 deletions packages/cli-repl/src/cli-repl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ class CliRepl {
this.bus.emit('mongosh:mongoshrc-load');
await this.mongoshRepl.loadExternalFile(mongoshrcPath);
} catch (err) {
this.output.write(this.clr('Error while running ~/.mongoshrc.js:\n', ['bold', 'yellow']));
this.output.write(this.mongoshRepl.writer(err) + '\n');
}
return;
Expand Down