fix(java-shell): allow console.warn and console.info #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eea5cd6 broke the waterfall tests, because BSON uses console.warn() when applied to the java shell as no secure random number generator is available, and the change upgraded the resulting error from a silent unhandled promise rejection to a full exception. Solve this by adding warn and info to the java-shell console for parity with the shell-api code.
rose-m
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eea5cd6 broke the waterfall tests, because BSON uses
console.warn() when applied to the java shell as no secure random
number generator is available, and the change upgraded the
resulting error from a silent unhandled promise rejection to a full
exception.
Solve this by adding warn and info to the java-shell console
for parity with the shell-api code.