Skip to content

fix(shell-api): include db name in collection print MONGOSH-927 #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2021
Merged

fix(shell-api): include db name in collection print MONGOSH-927 #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38db560
fix(shell-api): include db name in collection print MONGOSH-927
addaleax Jul 28, 2021
a1827d6
fixup: java shell test changes
addaleax Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/java-shell/src/test/resources/collection/ref.expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
collection
admin.collection
2 changes: 1 addition & 1 deletion packages/java-shell/src/test/resources/db/getCollection.expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
StringResult: does not exist
StringResult: test.does not exist
2 changes: 1 addition & 1 deletion packages/shell-api/src/collection.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('Collection', () => {
const coll = new Collection(mongo as any, db, 'myCollection');
it('toShellResult', async() => {
expect((await toShellResult(coll)).type).to.equal('Collection');
expect((await toShellResult(coll)).printable).to.equal('myCollection');
expect((await toShellResult(coll)).printable).to.equal('myDB.myCollection');
});
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/shell-api/src/collection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export default class Collection extends ShellApiWithMongoClass {
* Internal method to determine what is printed for this class.
*/
[asPrintable](): string {
return this._name;
return `${this._database.getName()}.${this._name}`;
}

/**
Expand Down