MONGOSH-956: Open external editor #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
force-pushed
the
MONGOSH-956-open-external-editor
branch
from
f62071d to
11bcf4d
Compare
addaleax
reviewed
Sep 10, 2021
alenakhineika
force-pushed
the
MONGOSH-956-open-external-editor
branch
from
7cdaa99 to
10c4761
Compare
addaleax
reviewed
Sep 10, 2021
alenakhineika
force-pushed
the
MONGOSH-956-open-external-editor
branch
from
52ff504 to
69e9766
Compare
addaleax
reviewed
Sep 14, 2021
alenakhineika
force-pushed
the
MONGOSH-956-open-external-editor
branch
from
eea96c3 to
39fae63
Compare
addaleax
reviewed
Sep 16, 2021
addaleax
reviewed
Sep 16, 2021
alenakhineika
force-pushed
the
MONGOSH-956-open-external-editor
branch
from
96bb6b1 to
d6da9e2
Compare
alenakhineika
force-pushed
the
MONGOSH-956-open-external-editor
branch
from
7a9e7bc to
73a5017
Compare
addaleax
reviewed
Sep 21, 2021
addaleax
approved these changes
Sep 21, 2021
addaleax
reviewed
Sep 21, 2021
addaleax
approved these changes
Sep 21, 2021
alenakhineika
added a commit
that referenced
this pull request
Sep 21, 2021
* feat: open external editor MONGOSH-956 * feat: reopen past content in the editor and log info * feat: open user specified editor * refactor: spawn child async * refactor: reduce complexity * feat: convert content to a single line and put into input stream * refactor: rename internalState to instanceState * feat: open code in editor * build: rebase from master and compile * test: add some basic unit tests * refactor: pass data as function args instead of storing it as class props * build: rebase from master and resolve conflicts * refactor: check for identifier instead of statement * fix: reopen the last content for empty edit command * feat: accept a raw input in editor * fix: properly handle raw empty editor case * docs: add read me * docs: add comments * fix: read and delete a temp file * refactor: remove ShellApiErrorsWrapper * refactor: add mode to writeFile * test: return expectedError as any test: add editor to the list of expected available config options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open an external editor from mongosh.