feat(editor): handle editor specifies as name with multiple parts MONGOSH-996 #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
changed the title
addaleax
approved these changes
Sep 22, 2021
addaleax
changed the title
alenakhineika
deleted the
MONGOSH-996-editor-name-with-multiple-parts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can specify something in the editor that contains multiple parts (eg EDITOR='nano -cA' or EDITOR='code --wait'). We could spawn the editor using a shell flag to support the following cases:
EDITOR=code
EDITOR=C:\Program Files\Editor\editor.exe
EDITOR="code --wait"
Since we cannot easily distinguish between the semantics of the spaces between cases 2 and 3, we will need the OS shell to do that for us.