test(editor): use a node script as an external editor MONGOSH-992 #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Sep 24, 2021
|
@addaleax Thx a lot for taking a look so quickly ❤️ |
addaleax
reviewed
Sep 29, 2021
alenakhineika
force-pushed
the
MONGOSH-992-e2e-tests-for-editor
branch
from
fb83766 to
cf04e0a
Compare
addaleax
reviewed
Sep 29, 2021
packages/editor/src/editor.spec.ts
Outdated
| const tmpDoc = process.argv[process.argv.length - 1]; | ||
| const { promises: { writeFile } } = require('fs'); | ||
| await writeFile(tmpDoc, \`${output}\`, { mode: 0o600 }); |
There was a problem hiding this comment.
Suggested change
| await writeFile(tmpDoc, \`${output}\`, { mode: 0o600 }); | |
| await writeFile(tmpDoc, ${JSON.stringify(output)}, { mode: 0o600 }); |
So that this doesn’t break if output contains a backtick or escape sequences?
There was a problem hiding this comment.
Well, I don't have these cases in my tests, so it doesn't :) If we want to cover such cases in tests I can replace it with JSON.stringify.
addaleax
reviewed
Sep 30, 2021
addaleax
approved these changes
Sep 30, 2021
alenakhineika
force-pushed
the
MONGOSH-992-e2e-tests-for-editor
branch
from
2594d59 to
a75d68f
Compare
alenakhineika
force-pushed
the
MONGOSH-992-e2e-tests-for-editor
branch
from
25402d6 to
57c0c63
Compare
addaleax
reviewed
Sep 30, 2021
| !(argv[0] ?? '').startsWith('(') | ||
| ) { | ||
| return shellApi[cmd](input); | ||
| const code = /^(\S+)$/.test(trimmedInput) ? '' : trimmedInput.replace(/^\S+\s+/, ''); |
There was a problem hiding this comment.
This is the same as
Suggested change
| const code = /^(\S+)$/.test(trimmedInput) ? '' : trimmedInput.replace(/^\S+\s+/, ''); | |
| const code = trimmedInput.replace(/^\S+\s*/, ''); |
right?
Also, I wouldn't call this code, it's code when it refers to the edit command but this is fairly generic, I would call it something like rawArgument or rawInput (also because that's consistent with acceptsRawInput elsewhere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check spawing processes by replacing an external editor with nodejs script.