chore(ci): do not run connectivity-tests as unit tests #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some macOS machines in CI have currently started using npm 7 by default. This has the consequence that npm complains about a missing `test` script in the connectivity-tests package. Since we eventually want to migrate to npm 7, we address this by adding a `test` script (and removing connectivity-tests from the unit test matrix), rather than enforcing usage of npm 6 everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some macOS machines in CI have currently started using npm 7 by
default. This has the consequence that npm complains about a
missing
testscript in the connectivity-tests package.Since we eventually want to migrate to npm 7, we address this
by adding a
testscript (and removing connectivity-testsfrom the unit test matrix), rather than enforcing usage of npm 6
everywhere.