-
Notifications
You must be signed in to change notification settings - Fork 79
test(editor): fake vscode as an external editor MONGOSH-1011 #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment, feel free to take it or leave it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny comment that could clarify the test description a bit, again, feel free to ignore if you like :)
const editorOutput = `const myObj = { | ||
field: { | ||
child: 'new value' | ||
context('when editor is path', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context('when editor is path', () => { | |
context('when editor is executable file', () => { |
Test a use case when code is selected as an external editor.