Skip to content

Conversation

alenakhineika
Copy link
Contributor

Test a use case when code is selected as an external editor.

@alenakhineika alenakhineika changed the title test: fake vscode as an external editor MONGOSH-1011 test(editor): fake vscode as an external editor MONGOSH-1011 Oct 4, 2021
@alenakhineika alenakhineika marked this pull request as ready for review October 4, 2021 14:54
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, feel free to take it or leave it :)

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny comment that could clarify the test description a bit, again, feel free to ignore if you like :)

const editorOutput = `const myObj = {
field: {
child: 'new value'
context('when editor is path', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
context('when editor is path', () => {
context('when editor is executable file', () => {

@alenakhineika alenakhineika merged commit 3c2d01b into main Oct 5, 2021
@alenakhineika alenakhineika deleted the MONGOSH-1011-e2e-test-code branch October 5, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants