feat(build): include manual file in packages MONGOSH-1017 #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Oct 27, 2021
addaleax
reviewed
Oct 27, 2021
There was a problem hiding this comment.
If I extract the .deb locally, it seems that ./usr/share/man/man1/mongosh.1.gz is a tar archive, not a gzipped file? I think some of the wiring is still not quite right here:
$ dpkg -x mongodb-mongosh_0.0.0-dev.0_amd64.deb .
$ file ./usr/share/man/man1/mongosh.1.gz
./usr/share/man/man1/mongosh.1.gz: POSIX tar archive
mabaasit
changed the title
addaleax
reviewed
Oct 28, 2021
addaleax
reviewed
Oct 29, 2021
addaleax
approved these changes
Nov 1, 2021
| tar.x({ cwd: destination }) | ||
| ); | ||
| await promisify(pipeline)( | ||
| createReadStream(join(destination, 'mongosh.1')), |
There was a problem hiding this comment.
Suggested change
| createReadStream(join(destination, 'mongosh.1')), | |
| createReadStream(join(destination, path.basename(name, '.gz'))), |
addaleax
changed the title
addaleax
added a commit
that referenced
this pull request
Nov 3, 2021
This implements the (optional) review comment in #1144 (comment), it’s nice to avoid hardcoding things that are also available through the build config file.
addaleax
added a commit
that referenced
this pull request
Nov 24, 2021
* chore(build): avoid hardcoding manpage name This implements the (optional) review comment in #1144 (comment), it’s nice to avoid hardcoding things that are also available through the build config file. * fixup: refactor rpm manpage inclusion code * chore: add man page checks to test rpm/deb docker setups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement manual pages for the packages.
Adds mongosh manpages to all the packages except for
win32msi.For
.deb