Skip to content

fix(cli-repl): work around Windows libuv TTY bug MONGOSH-998 #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2021
Merged

fix(cli-repl): work around Windows libuv TTY bug MONGOSH-998 #1147

merged 2 commits into from
Nov 2, 2021

Conversation

addaleax
Copy link
Collaborator

@addaleax addaleax commented Nov 1, 2021

No description provided.

gribnoysup
gribnoysup approved these changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@gribnoysup gribnoysup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for such an in-depth description of the cause and how the workaround should solve it. This sounds good to me and even though I couldn't test it, seems like it works for reporters in the JIRA ticket

@addaleax addaleax merged commit d48113d into main Nov 2, 2021
@addaleax addaleax deleted the 998-dev-2 branch November 2, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @gribnoysup