Skip to content

fix(shell-api): add toBSON overrides to MinKey/MaxKey ctors MONGOSH-1024 #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2021
Merged

fix(shell-api): add toBSON overrides to MinKey/MaxKey ctors MONGOSH-1024 #1154

merged 2 commits into from
Nov 17, 2021

Conversation

addaleax
Copy link
Collaborator

Add .toBSON overrides so that sending MinKey or MaxKey
over the wire results in the same document that MinKey() or
MaxKey() would have generated, for compatibility with the
legacy shell.

@addaleax
fix(shell-api): add toBSON overrides to MinKey/MaxKey ctors MONGOSH-1024
549ea5f 


Add `.toBSON` overrides so that sending `MinKey` or `MaxKey`
over the wire results in the same document that `MinKey()` or
`MaxKey()` would have generated, for compatibility with the
legacy shell.
@addaleax
fixup: lint
579a43c
@addaleax addaleax merged commit 3b36e62 into main Nov 17, 2021
@addaleax addaleax deleted the 1024-dev branch November 17, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@addaleax @gribnoysup