Skip to content

Revert "chore(build): skip attempted PGP signing for now (#1174)" #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Revert "chore(build): skip attempted PGP signing for now (#1174)" #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/build/src/run-draft.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,15 @@ describe('draft', () => {
});

it('asks the notary service to sign files', () => {
// expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
});

it('uploads artifacts to download center', () => {
expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
// expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
});

it('uploads the artifacts to the github release', () => {
expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
// expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
});
});

Expand Down
6 changes: 1 addition & 5 deletions packages/build/src/run-draft.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ export async function runDraft(
tmpDir
);

/*
// pending https://jira.mongodb.org/browse/BUILD-14385
await notarizeArtifact(
tarballFile.path,
{
Expand All @@ -55,12 +53,10 @@ export async function runDraft(
}
);
const signatureFile = tarballFile.path + '.sig';
*/
void notarizeArtifact;

await Promise.all([
[ downloadedArtifact, tarballFile.contentType ],
// [ signatureFile, 'application/pgp-signature' ]
[ signatureFile, 'application/pgp-signature' ]
].flatMap(([ path, contentType ]) => [
uploadToDownloadCenter(
path,
Expand Down