feat: add support for --tlsUseSystemCA flag COMPASS-4105 #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Feb 21, 2022
|
|
||
| const logPath = path.join(logBasePath, `${shell.logId}_log`); | ||
| const logContents = await readReplLogfile(logPath); | ||
| expect(logContents.find(line => line.id === 1_000_000_049)).to.exist; |
There was a problem hiding this comment.
If this test checks that the loading from system CA should fail on these systems, wouldn't this log line be missing from the log file? IIUC 1_000_000_049 shows in the logs when we managed to read from system CA
There was a problem hiding this comment.
Right, this is to verify that the feature is actually working, i.e. loading from system CA does not fail. It just happens to fail until we have mongodb-js/boxednode#24, because the system-ca case is one in which the bindings package’s filename detection logic breaks down.
There was a problem hiding this comment.
Ahhh, got it! Totally misread the test case name
gribnoysup
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.