fix(node-runtime-worker-thread): externalize system-ca and deps #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SS-4105 In order to be usable in Compass, system-ca and its addon dependencies need to be externalized in the webpack configuration. Theoretically, it might be enough to only externalize the addons; however, since system-ca prefers to use worker threads for loading certificates asynchronously on macOS and Windows, and we need to externalize *something*, it makes sense to do it on the system-ca level.
10 tasks
mcasimir
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-4105
In order to be usable in Compass, system-ca and its addon dependencies
need to be externalized in the webpack configuration.
Theoretically, it might be enough to only externalize the addons;
however, since system-ca prefers to use worker threads for loading
certificates asynchronously on macOS and Windows, and we need to
externalize something, it makes sense to do it on the system-ca
level.