feat(cli-repl): pass through sspiHostnameCanonicalization to driver MONGOSH-856 #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
changed the title
…ONGOSH-856 Pass down `sspiHostnameCanonicalization` to the driver as-is and let the driver do the validation. We still map `true` and `false` from strings to booleans and an empty string to `undefined`, since the driver would otherwise reject those values.
gribnoysup
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONGOSH-856
Pass down
sspiHostnameCanonicalizationto the driver as-isand let the driver do the validation. We still map
trueandfalsefrom strings to booleans and an empty string toundefined,since the driver would otherwise reject those values.