feat(shell-api): add support for snapshot reads MONGOSH-1151 #1237
Conversation
packages/shell-api/src/mongo.ts
Outdated
| // support for a newly introduced driver option when it is being added | ||
| // to the driver API. | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const __typecheck1: (typeof allTransactionOptions)[number] = '' as Exclude<keyof TransactionOptions, keyof CommandOperationOptions>; |
There was a problem hiding this comment.
Don't have a strong preference really, but it took me awhile to grasp what's exactly is going on there, at the same time I used something like this before (which provides the same result and also doesn't require eslint-disable):
function assertAllOptionsUsed(options: Exclude<keyof TransactionOptions, keyof CommandOperationOptions>) {
// These typechecks might look weird, but will tell us if we are missing
// support for a newly introduced driver option when it is being added
// to the driver API.
}
assertAllOptionsUsed(allTransactionOptions)EDIT: yikes, I think this particular snippet doesn't work, sorry, but the idea would be to use a noop function to do the assertion instead of using as operator. But now I'm thinking that maybe I'm just misunderstanding how this works and so feel free to ignore this 😅
There was a problem hiding this comment.
Well, your suggestion is basically to use a function call instead of an assignment, right? That’s easy enough to do, updated the code here :) Still needs eslint comments, though, because the argument is unused.
No description provided.