feat: bump Node.js to 16.x MONGOSH-1219 #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
changed the title
addaleax
commented
May 16, 2022
| import shlex | ||
| import subprocess | ||
| import shutil | ||
| -import bz2 |
There was a problem hiding this comment.
This package is just not available on s390x with Python 3 – see the old comment in compile-artifact.sh above about it.
| "$CONNECTIVITY_TEST_SOURCE_DIR/ldap.sh" | ||
| "$CONNECTIVITY_TEST_SOURCE_DIR/localhost.sh" | ||
| "$CONNECTIVITY_TEST_SOURCE_DIR/atlas.sh" | ||
| "$CONNECTIVITY_TEST_SOURCE_DIR/kerberos.sh" |
There was a problem hiding this comment.
Drive-by fix: This seems better, since it isolates the scripts more strongly, and exit 0 inside the script would not exit all the tests at once (previously e.g. the kerberos tests would always be skipped if no atlas credentials were in the environment)
| echo "Atlas credentials are not provided" | ||
|
|
||
| if [[ -z "${IS_CI}" ]] || [[ -z "${CI}" ]]; then | ||
| if [[ -n "${IS_CI}" ]] || [[ -n "${CI}" ]]; then |
There was a problem hiding this comment.
Also drive-by fix, these were just typos
Anemy
reviewed
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.