feat(ci): create shared-openssl binaries MONGOSH-1223 #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
May 20, 2022
| "--shared-openssl-includes=/tmp/m/opt/include", | ||
| "--shared-openssl-libpath=/tmp/m/opt/lib", | ||
| "--shared-openssl-libname='"$MONGOSH_OPENSSL_LIBNAME"'", | ||
| "--shared-zlib" |
There was a problem hiding this comment.
I don’t know why specifically this is necessary, but it’s definitely related to the Node.js build system being a bit wonky around zlib support (because Node.js itself doesn’t bundle the original zlib, and instead uses an API-compatible fork from Chromium). I guess the --shared-openssl setting has some influence on the zlib build. In any case, this should be fairly unproblematic since zlib is almost universally available on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.