Skip to content

Conversation

addaleax
Copy link
Collaborator

Proper testing of the functionality is left to MONGOSH-1222.

This does not add support for --sslFIPSMode or spelling variants
of --tlsFIPSMode that would be recognized by yargs, in order to
keep the setup code as straightforward as possible.

Proper testing of the functionality is left to MONGOSH-1222.

This does not add support for `--sslFIPSMode` or spelling variants
of `--tlsFIPSMode` that would be recognized by yargs, in order to
keep the setup code as straightforward as possible.
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one question on possible test improvement, not a blocker.

@addaleax addaleax merged commit bad5ed8 into main May 25, 2022
@addaleax addaleax deleted the 1221-dev branch May 25, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants