chore: replace references to csfle shared library MONGOSH-1237 #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
May 30, 2022
packages/cli-repl/src/arg-parser.ts
Outdated
| 'awsSessionToken', | ||
| 'awsIamSessionToken', | ||
| 'csfleLibraryPath', | ||
| 'cryptLibraryPath', |
There was a problem hiding this comment.
I think I’ll need to wait for confirmation on the new driver option name (if it is being changed) here Done!
Anemy
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
lgtm! mongodb-js/devtools-connect#14 looks good too.
There's a ci failure:
TSError: ⨯ Unable to compile TypeScript:
[2022/06/01 11:54:08.785] Z:/data/mci/c5d7e18cf372b91a8867fb832e5d2788/src/testing/integration-testing-hooks.ts(13,38): error TS2307: Cannot find module '../packages/build/src/packaging/download-csfle-library' or its corresponding type declarations.
We probably want to address before merging though?
I’ll do my best to get CI as green as it can be ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need mongodb-js/devtools-connect#14 as well