fix(cli-repl): flush output before exiting MONGOSH-1300 #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch { /* ignore */ } | ||
| } else { | ||
| // .end() has not been called; write an empty chunk and wait for it to be fully written. | ||
| await new Promise(resolve => this.output.write('', resolve)); |
There was a problem hiding this comment.
Why do we write this empty chunk? To verify it is still writable?
There was a problem hiding this comment.
As the comment says, the goal here is to wait for the chunk to be fully written; because when the new chunk has been written, that implies that all previously pending data has also been written to the underlying stream.
alenakhineika
approved these changes
Dec 5, 2022
kmruiz
added a commit
that referenced
this pull request
Jul 26, 2023
kmruiz
added a commit
that referenced
this pull request
Aug 1, 2023
kmruiz
added a commit
that referenced
this pull request
Aug 3, 2023
…ONGOSH-1369 (#1537) * feat: Add new factory for ObjectId and Binary New methods: ObjectId.createFromHexString Binary.createFromBase64 * feat: Change how Binary is printed in the REPL - #1369 * fix(style): Remove unnecessary casting to 'any' as the NodeJS driver already exposes the method * fix: remove .only so all tests run * fix(test): Fix e2e tests * fix(test): Remove .only from tests so it runs everything * fix(test): Fix e2e tests * fix(tests): Fix E2E FLE test * fix(tests): Fix E2E FLE test on bypassQueryAnalysis * chore: Remove unnecessary command in package.json Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com> * chore: Fix e2e test for MongoDB 7.0 * chore: Fix e2e tests configuration MONGOSH-1369 --------- Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.