chore(shell-api): check StaleConfig error codeName in addition to code number #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e number The server team has confirmed that they prefer for downstream teams to check error codeName values rather than (only) code numbers, as the latter may go away when code is being refactored.
himanshusinghs
approved these changes
Aug 4, 2023
|
Where are these error codes documented? |
|
@himanshusinghs Not sure what you’re looking for in terms of documentation, but https://github.com/mongodb/mongo/blob/1c3fb19ac8e5690e81617e815f122d8a868804a3/src/mongo/base/error_codes.yml is the source of truth for the list of all of the error codes. I’m not sure if there’s proper documentation for these beyond that file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server team has confirmed that they prefer for downstream teams to check error codeName values rather than (only) code numbers, as the latter may go away when code is being refactored.
(Opened COMPASS-7082 and MONGOSH-1554 to track the other instances of this.)