chore: use sinon from the sinon package where possible, not ts-sinon MONGOSH-1501 #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Aug 15, 2023
Anemy
approved these changes
Aug 15, 2023
|
Something was up with the evergreen integration here, but this is the green run https://spruce.mongodb.com/version/64dcfb912fbabe75dc5ea469/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change normalises all standard usage of sinon to be from the sinon package, not from the ts-sinon package. The only usage of ts-sinon that's left relates to the usage of the deprecated
stubInterfacefunction in ts-sinon. Consequently StubbedInstance is still imported from ts-sinon as well. There's a SinonStubbedInstance in sinon itself, but it is not compatible.I didn't immediately see how to replace stubInterface, but I suppose we can do that in a follow-up. At that point we can remove the ts-sinon package completely.