Skip to content

Conversation

kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Aug 23, 2023

No description provided.

@addaleax addaleax changed the title chore: Group download center packages by platform MONGOSH-1346 chore: group download center packages by platform MONGOSH-1346 Aug 23, 2023
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, just wanted to say though, the ticket description mentions a few things we want to take care of as part of this ticket:

We currently provide multiple downloads for some platforms (e.g.: Windows .zip/.msi, Linux static/openssl11/openssl3). We should group those by platform like other tools do, so that it’s easier to find the right download, instead of referring to these downloads as different platforms.

We should also be more consistent in platform naming; e.g. consistently use RHEL instead of Redhat, x64 instead of 64-bit, and include minimum platform versions.

We can merge this once CI is green and take care of that in a follow-up PR if you prefer 👍

@kmruiz
Copy link
Contributor Author

kmruiz commented Aug 23, 2023

I'm fine doing these changes in one single PR, they should be straightforward now that we have the new schema. I'm wondering if openssl{1,3} should be considered different packages of the same platform or not. It should be pretty easy to fix now.

@kmruiz kmruiz merged commit 960f621 into main Aug 24, 2023
@kmruiz kmruiz deleted the feature/MONGOSH-1346 branch August 24, 2023 07:50
kmruiz added a commit that referenced this pull request Aug 25, 2023
kmruiz added a commit that referenced this pull request Aug 25, 2023
@kmruiz kmruiz restored the feature/MONGOSH-1346 branch September 6, 2023 11:35
@kmruiz kmruiz deleted the feature/MONGOSH-1346 branch September 6, 2023 11:35
@kmruiz kmruiz restored the feature/MONGOSH-1346 branch September 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants