-
Notifications
You must be signed in to change notification settings - Fork 79
chore: group download center packages by platform MONGOSH-1346 #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM, just wanted to say though, the ticket description mentions a few things we want to take care of as part of this ticket:
We currently provide multiple downloads for some platforms (e.g.: Windows .zip/.msi, Linux static/openssl11/openssl3). We should group those by platform like other tools do, so that it’s easier to find the right download, instead of referring to these downloads as different platforms.
We should also be more consistent in platform naming; e.g. consistently use RHEL instead of Redhat, x64 instead of 64-bit, and include minimum platform versions.
We can merge this once CI is green and take care of that in a follow-up PR if you prefer 👍
I'm fine doing these changes in one single PR, they should be straightforward now that we have the new schema. I'm wondering if openssl{1,3} should be considered different packages of the same platform or not. It should be pretty easy to fix now. |
No description provided.