Skip to content

Conversation

lrlna
Copy link
Contributor

@lrlna lrlna commented May 14, 2020

Description

This got accidentally removed when adding eslint to cli-repl package. Adding it
back in.

Copy link
Collaborator

@mcasimir mcasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This would be a great test case for an e2e test.

@@ -1,4 +1,5 @@
#!/usr/bin/env node
#!/bin/sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick! Is this how it was done before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it was!

@lrlna
Copy link
Contributor Author

lrlna commented May 14, 2020

@mcasimir added a test as well, good point.

});

it('does not throw for a repl await function', async() => {
shell.stdio.stdin.write('await Promise.resolve(\'Nori-cat\');');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐱

@lrlna lrlna merged commit 8e9f6b7 into master May 14, 2020
@lrlna lrlna deleted the node-await-flag branch May 14, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants