Skip to content

fix: use setupRepl when connecting with username/password #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

fix: use setupRepl when connecting with username/password #184

merged 1 commit into from
May 15, 2020

Conversation

lrlna
Copy link
Contributor

@lrlna lrlna commented May 14, 2020

Description

When requiring password, make sure we:

  1. use setupRepl() instead of connect() function
  2. catch and log the errors when setting up the REPL and when reading password
    options.

@lrlna lrlna merged commit 61141d8 into master May 15, 2020
@lrlna lrlna deleted the try-catch-password-prompt branch May 15, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lrlna