Skip to content

chore(cli-repl): relax macOS --tlsCertificateSelector test expectations #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

chore(cli-repl): relax macOS --tlsCertificateSelector test expectations #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli-repl/src/tls-certificate-selector.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe('arg-mapper.applyTlsCertificateSelector', function () {
return this.skip();
}
expect(() => getTlsCertificateSelector('subject=Foo Bar')).to.throw(
/Could not find a matching certificate/
/Could not find a matching certificate|The specified item could not be found in the keychain/
);
});
});
Expand Down
4 changes: 3 additions & 1 deletion packages/e2e-tests/test/e2e-tls.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,9 @@ describe('e2e TLS', function () {
'Could not resolve certificate specification'
);
} else if (process.platform === 'darwin') {
shell.assertContainsOutput('Could not find a matching certificate');
shell.assertContainsOutput(
/Could not find a matching certificate|The specified item could not be found in the keychain/
);
} else {
shell.assertContainsOutput(
'tlsCertificateSelector is not supported on this platform'
Expand Down