Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented May 27, 2020

https://jira.mongodb.org/browse/COMPASS-4294

This PR has 2 small improvements for the shell plugin interaction (changes are in browser-repl):

Screenshots


May-27-2020 12-58-42

@Anemy Anemy requested a review from mcasimir May 27, 2020 11:03
Copy link
Contributor

@alenakhineika alenakhineika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only some tests need to be fixed before merging. Currently, Windows tests are not passing on evergreen.

Copy link
Contributor

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ✨

we've been having issues with windows tests. I'd just rerun them again, to make sure it's an actual issue.

@Anemy Anemy merged commit bae7424 into master Jun 3, 2020
@Anemy Anemy deleted the COMPASS-4294/improve-shell-plugin-interaction branch June 3, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants