Skip to content

fix(browser-repl): make sure we are actually using initial value of initialEvaluate #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(browser-repl): make sure we are actually using initial value of initialEvaluate #2058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/browser-repl/src/components/shell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,18 @@ export class Shell extends Component<ShellProps, ShellState> {
};

componentDidMount(): void {
// Store the intial prop value on mount so that we're not using potentially
// updated one when actually running the lines
let evalLines: string[] = [];
if (this.props.initialEvaluate) {
evalLines = Array.isArray(this.props.initialEvaluate)
? this.props.initialEvaluate
: [this.props.initialEvaluate];
}
this.scrollToBottom();
void this.updateShellPrompt().then(async () => {
if (this.props.initialEvaluate) {
const evalLines = Array.isArray(this.props.initialEvaluate)
? this.props.initialEvaluate
: [this.props.initialEvaluate];
for (const input of evalLines) {
await this.onInput(input);
}
for (const input of evalLines) {
await this.onInput(input);
}
});
}
Expand Down