Skip to content

fix CLI args not getting used #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2020
Merged

fix CLI args not getting used #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/cli-repl/src/uri-generator.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ describe('uri-generator.generate-uri', () => {
});
});

context('when no URI is provided', () => {
it('handles host', () => {
expect(generateUri({ _: [], host: 'localhost'})).to.equal('mongodb://localhost:27017')
});
it('handles port', () => {
expect(generateUri({ _: [], port: '27018' })).to.equal('mongodb://127.0.0.1:27018')
});
});

context('when a full URI is provided', () => {
context('when no additional options are provided', () => {
const uri = 'mongodb://192.0.0.1:27018/foo';
Expand Down
7 changes: 4 additions & 3 deletions packages/cli-repl/src/uri-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function validateConflicts(options: CliOptions): any {
*
* @returns {string} The host.
*/
function generateHost(options: CliOptions = {}): string {
function generateHost(options: CliOptions): string {
return options.host ? options.host : DEFAULT_HOST;
}

Expand All @@ -72,7 +72,8 @@ function generateHost(options: CliOptions = {}): string {
*
* @returns {string} The port.
*/
function generatePort(options: CliOptions = {}): string {
function generatePort(options: CliOptions): string {
console.log(`in generatePort, options=${options.port}`);
return options.port ? options.port : DEFAULT_PORT;
}

Expand All @@ -97,7 +98,7 @@ function generateUri(options: CliOptions): string {

// There is no URI provided, use default 127.0.0.1:27017
if (!uri) {
return `${Scheme.Mongo}${generateHost()}:${generatePort()}`;
return `${Scheme.Mongo}${generateHost(options)}:${generatePort(options)}`;
}

// A mongodb:// or mongodb+srv:// URI is provided, treat as correct.
Expand Down