Connect to DB in URI initially #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherlihy
force-pushed
the
db
branch
2 times, most recently
from
9a97422 to
8a2e0cd
Compare
|
I think the tests failing on windows, are actual fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbto that DB on connect. Also addDEFAULT_DBto service provider core so that we have one place where we set the initial db.connectornew Mongo, otherwiseconnect('localhost:27017')will fail since the driver doesn't accept that URI.connect(<uri>/<db>), to avoid having to write our own uri parser (and we can't use the node driver one since the URIs need to be called from the shell-api (which is required by browser/etc), we get the initial DB via the service provider. This means that it will connect to the DB set in the URI in both the CLI and Compass.