exit if node version too low #226
Conversation
packages/cli-repl/src/cli-repl.ts
Outdated
| console.log(`${clr('Using Mongosh Beta', ['bold', 'yellow'])}: ${version}`); | ||
| console.log(`${MONGOSH_WIKI}`); | ||
| if (semver.lt(process.version, engines.node.replace('^', ''))) { | ||
| console.log(`WARNING: mismatched node version. Minimum node version required ${engines.node}. Currently using ${process.version}. Exiting...\n\n`); |
There was a problem hiding this comment.
Maybe let's throw an MongoshUnsupportedError here?
Message is really good though -- super clear with node versions, hopefully will lead to less bug reports.
There was a problem hiding this comment.
We don't have unsupported, we only have unimplemented, which I think doesn't match this use case. I can change it to RuntimeError
Actually it doesn't make sense to throw an error right before exiting because we would need to catch that error otherwise the process.exit code is unreachable. I moved the check to the constructor so we don't have a writer either. I think it should stay as is.
|
(omg sorry for all the comments on such a tiny PR 😅 😅 😅 ) |
|
Never a problem on the many comments, I opened this PR as a way of starting this conversation :) |
3 participants
Should we exit or just warn?