Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Jun 22, 2020

https://jira.mongodb.org/browse/MONGOSH-210

This PR makes it so the shell retains its output when its collapsed and re-opened.
It also adds a hotkey Command-L/Ctrl-L (Mac/Windows) which clears the output of the shell.

We had an error in compass-shell where signatures from the shell api weren't loading correctly, this PR fixes that by moving the signature references into the completer so that they're referenced at runtime, since we build the signatures object from the decorator. https://github.com/mongodb-js/mongosh/pull/240/files#diff-6635c7669eeb4f2b6ed7cfb2857f389eL19


Jun-22-2020 13-58-38
Screen Shot 2020-06-22 at 1 56 57 PM

Before merging:

  • Manually tested with a large amount of output to ensure its not laggy on collapse/expand. It takes a half second to expand but it works fine.

@Anemy
Copy link
Member Author

Anemy commented Jun 22, 2020

@aherlihy just heads up, doing a small change on completion signatures here: https://github.com/mongodb-js/mongosh/pull/240/files#diff-6635c7669eeb4f2b6ed7cfb2857f389eL19
I think Irina had done some work on pulling the autocompleter into its own package so we can remove the cli-repl dependency from browser-repl

@Anemy Anemy requested a review from mcasimir June 22, 2020 14:31
Copy link
Collaborator

@mcasimir mcasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Anemy Anemy force-pushed the COMPASS-4157/preserve-shell-state-when-collapsing branch from ec6f3d7 to b880a7a Compare June 30, 2020 20:35
@Anemy Anemy merged commit 6e5f065 into master Jun 30, 2020
@Anemy Anemy deleted the COMPASS-4157/preserve-shell-state-when-collapsing branch June 30, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants