Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented Jul 1, 2020

Run e2e tests on compiled binaries

@mcasimir mcasimir added the wip Work in Progress label Jul 1, 2020
@mcasimir mcasimir force-pushed the run-e2e-test-on-binaries branch from d11de9c to 9eb9eb2 Compare July 1, 2020 13:23
import assert from 'assert';

const PROMPT_PATTERN = /^> /m;
const ERROR_PATTERN = /Thrown:\n([^>]*)/m;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go in a separate PR since it's a separate issue?

Copy link
Collaborator Author

@mcasimir mcasimir Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without that change tests break when running on the compiled binary since the node version is slightly different from the one downloaded in the CI vm

@mcasimir mcasimir removed the wip Work in Progress label Jul 3, 2020
@mcasimir mcasimir changed the title test on compiled binaries Run e2e tests on compiled binaries Jul 3, 2020
@mcasimir mcasimir merged commit 8949e04 into master Jul 3, 2020
@mcasimir mcasimir deleted the run-e2e-test-on-binaries branch July 3, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants