Skip to content

chore(release) fix iam role used for dry run releases DEVPROD-21408 #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

chore(release) fix iam role used for dry run releases DEVPROD-21408 #2525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .evergreen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4810,6 +4810,9 @@ functions:
params:
file: tmp/expansions.yaml
redacted: true
- command: ec2.assume_role
params:
role_arn: "arn:aws:iam::119629040606:role/s3-access.cdn-origin-compass"
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IAM role ARN is hardcoded with a specific AWS account ID (119629040606). Consider using an environment variable or parameter to make this configurable across different environments and avoid exposing account details in the codebase.

Copilot uses AI. Check for mistakes.

- command: shell.exec
# silent: true
params:
Expand All @@ -4818,6 +4821,9 @@ functions:
env:
devtoolsbot_npm_token: ${devtoolsbot_npm_token}
node_js_version: ${node_js_version}
DOWNLOAD_CENTER_AWS_KEY_ARTIFACTS: ${AWS_ACCESS_KEY_ID}
DOWNLOAD_CENTER_AWS_SECRET_ARTIFACTS: ${AWS_SECRET_ACCESS_KEY}
DOWNLOAD_CENTER_AWS_SESSION_TOKEN_ARTIFACTS: ${AWS_SESSION_TOKEN}
script: |
set -e
.evergreen/run-evergreen-release.sh publish -- --dry-run
Expand Down
6 changes: 6 additions & 0 deletions .evergreen/evergreen.yml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,9 @@ functions:
params:
file: tmp/expansions.yaml
redacted: true
- command: ec2.assume_role
params:
role_arn: "arn:aws:iam::119629040606:role/s3-access.cdn-origin-compass"
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IAM role ARN is hardcoded with a specific AWS account ID (119629040606). Consider using an environment variable or parameter to make this configurable across different environments and avoid exposing account details in the codebase.

Copilot uses AI. Check for mistakes.

- command: shell.exec
# silent: true
params:
Expand All @@ -1015,6 +1018,9 @@ functions:
env:
devtoolsbot_npm_token: ${devtoolsbot_npm_token}
node_js_version: ${node_js_version}
DOWNLOAD_CENTER_AWS_KEY_ARTIFACTS: ${AWS_ACCESS_KEY_ID}
DOWNLOAD_CENTER_AWS_SECRET_ARTIFACTS: ${AWS_SECRET_ACCESS_KEY}
DOWNLOAD_CENTER_AWS_SESSION_TOKEN_ARTIFACTS: ${AWS_SESSION_TOKEN}
script: |
set -e
.evergreen/run-evergreen-release.sh publish -- --dry-run
Expand Down
Loading