Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented Jul 30, 2020

Changes:

  1. Only download chromium in CI and use it if necessary.
  2. Add few commands to the main package.json:
    • bootstrap-with-chromium: always download chromium
    • bootstrap-without-compass: do not link and install compass-shell
    • bootstrap-ci: used in evergreen, run lerna and npm commands in 'ci' mode: without altering package-lock.json
  3. bootstrap will not run the prepublish script anymore. This means that compile-ts and webpack are not run automatically on every install.

@mcasimir mcasimir force-pushed the speed-local-setup branch from a1ac372 to 728923b Compare July 31, 2020 09:27
Copy link
Contributor

@aherlihy aherlihy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, one question: is there a reason we don't want to compile-ts when we bootstrap? It pretty much needs to happen each time you bootstrap since you wouldn't bootstrap without having some code changes or wanting to build

@mcasimir
Copy link
Collaborator Author

SGTM, one question: is there a reason we don't want to compile-ts when we bootstrap? It pretty much needs to happen each time you bootstrap since you wouldn't bootstrap without having some code changes or wanting to build

compile-ts was run as part of prepublish that's why is gone. npm run start[-*] also does compile-ts, should not be an issue, but we can do a postbootstrap: "compile everything except browser". Let me know.

@mcasimir mcasimir force-pushed the speed-local-setup branch from 613d3b5 to 867a0e5 Compare July 31, 2020 14:32
@mcasimir mcasimir force-pushed the speed-local-setup branch from 9b33733 to 8f6165e Compare July 31, 2020 17:26
@mcasimir mcasimir closed this Aug 3, 2020
@mcasimir mcasimir reopened this Aug 3, 2020
@mcasimir mcasimir merged commit 97e830e into master Aug 3, 2020
@mcasimir mcasimir deleted the speed-local-setup branch August 3, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants