Skip to content

fix: skip release if is patch #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

fix: skip release if is patch #325

merged 1 commit into from
Sep 15, 2020

Conversation

mcasimir
Copy link
Collaborator

No description provided.

addaleax
addaleax approved these changes Sep 15, 2020
View reviewed changes
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and I’m not seeing how this could break anything, but this feels a bit odd… what does IS_PATCH correspond to exactly? Does it distinguish between a tag/not a tag? Does it matter that this check isn’t done locally?

@mcasimir
Copy link
Collaborator Author

The code looks good, and I’m not seeing how this could break anything, but this feels a bit odd… what does IS_PATCH correspond to exactly?

At this point I'm not sure I know. It seems evergreen gives us an IS_PATCH variable that should be "true" for PRs commit and false in "master".

Does it matter that this check isn’t done locally?

What do you mean with "locally", like in our machines?

@mcasimir mcasimir merged commit 6060dd7 into master Sep 15, 2020
@mcasimir mcasimir deleted the fix-is-master-check branch September 15, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcasimir @addaleax