chore: add back support for generating signable binaries #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `boxednode` to create binaries that are compiled in a way that should enable us to sign them. `pkg` is retained as a helper for local development, since it requires no native compilation.
addaleax
commented
Sep 22, 2020
addaleax
commented
Sep 22, 2020
mcasimir
approved these changes
Sep 22, 2020
addaleax
force-pushed
the
boxednode
branch
5 times, most recently
from
d1a690c to
9ad21ab
Compare
mcasimir
reviewed
Sep 24, 2020
| display_name: "RHEL 8.0" | ||
| run_on: rhel80-large | ||
| display_name: "RHEL 8.0 (in Ubuntu docker)" | ||
| run_on: ubuntu1804-test |
There was a problem hiding this comment.
ubuntu1804-test has docker installed?
mcasimir
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
boxednodeto create binaries that are compiled in a waythat should enable us to sign them.
pkgis retained as ahelper for local development, since it requires no native compilation.
Fixes MONGOSH-226