Skip to content

Create cursors with expected Mongo instance #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2020
Merged

Create cursors with expected Mongo instance #340

merged 1 commit into from
Sep 24, 2020
+3 −3

Conversation

kornilova203
Copy link
Collaborator

Cursors were created with Collection and Database instances instead of expected Mongo

addaleax
addaleax approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Curious that typescript doesn’t catch this, though

@kornilova203 kornilova203 merged commit 7c712d1 into mongodb-js:master Sep 24, 2020
@kornilova203 kornilova203 deleted the fix-links-to-mongo-in-cursors branch September 24, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kornilova203 @addaleax